[REL-4161] Cblackburn/rel 4161/fix release action config - #524
Merged
Conversation
launchdarkly-upra
Bot
changed the title
blaqbern
marked this pull request as ready for review
July 24, 2025 22:05
blaqbern
enabled auto-merge (squash)
July 24, 2025 22:05
sheenacarswell
approved these changes
Jul 24, 2025
sheenacarswell
left a comment
sheenacarswell
left a comment
There was a problem hiding this comment.
Approving as this seems plausible, but I'm not an expert here
blaqbern
commented
Jul 24, 2025
Comment on lines
-63
to
+67
| - name: Commit changes and tag | ||
| run: | | ||
| ./scripts/release/commit-and-tag.sh | ||
| - name: Create Github release | ||
| ls -1a "$ARTIFACT_DIRECTORY" | ||
| - name: commit changes and tag | ||
| run: ./scripts/release/commit-and-tag.sh | ||
| - name: create Github release |
Contributor
Author
There was a problem hiding this comment.
The diff looks so weird here, but this is just lower-casing the names for consistency and some other minor cleanup/logging. The order is not changing here, even though it kinda looks like it from the diff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copying artifacts a temporary directory so they can be picked up by
ncipollo/release-action. This is the last piece that was missing, I think. I ran a dry run successfully and the CHANGELOG, diff and artifacts all looked correct. Also a bit of minor cleanup here as this should be just about finished now.Related Jira issue: REL-4161: Migrate ld-find-code-refs from Releaser to GHA